Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: macOS has incorrect capitalization #538

Open
ghost opened this issue May 10, 2023 · 2 comments
Open

[Bug]: macOS has incorrect capitalization #538

ghost opened this issue May 10, 2023 · 2 comments
Labels
bug Something isn't working new Issue not yet reviewed

Comments

@ghost
Copy link

ghost commented May 10, 2023

Contact Details

rebecca@bsdio.com

Describe the Bug

On the May 8th tools call, I noticed the macOS directory/archive was named 'MacOs'.
It would be nice if the capitalization was fixed to be either 'MacOS', or more correctly 'macOS' (see https://www.apple.com/macos/ventura/).

What Python version are you using?

Python 3.11

Reproduction steps

N/A

Expected behavior

N/A

Execution Environment

No response

Pip packages

No response

Additional context

No response

@ghost ghost added bug Something isn't working new Issue not yet reviewed labels May 10, 2023
@makubacki
Copy link
Member

At least whenever I originally saw the case chosen, I preferred Pascal case because:

  1. This project is within TianoCore and it is "edk2" pytool extensions and the EDK II C Coding Standard - Directory Names section explicitly uses Pascal case (e.g. IA32 -> Ia32, DXE -> Dxe, etc.).
  2. From a programmatic standpoint, this directory name is consumed by other code, and I prefer consistency of those names rather than arbitrary naming choices which makes things especially more straightforward on case-sensitive systems.

If Pascal case is kept, it would be nice to change ARM to Arm. If case is matched to the origin name, I'd prefer macOS.

I don't really have a strong opinion either way just wanted to provide my perspective.

@ghost
Copy link
Author

ghost commented May 10, 2023

If Pascal case is kept, I'd prefer 'Macos' or "macos", treating it as a single word.
"Arm" is really more correct nowadays, except if you're referring to the Architecture Reference Manual!
They changed the capitalization from 'ARM' to 'Arm' in 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new Issue not yet reviewed
Projects
None yet
Development

No branches or pull requests

1 participant