Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger family functions don't use the ID type #968

Closed
matthewkaney opened this issue Nov 15, 2022 · 1 comment · Fixed by #970
Closed

trigger family functions don't use the ID type #968

matthewkaney opened this issue Nov 15, 2022 · 1 comment · Fixed by #970

Comments

@matthewkaney
Copy link
Collaborator

Describe the bug

The trigger functions got left behind in the move from Show to an ID type, which means that they no longer work with string keys, for example:

p "looper" $ qtrigger "looper" $ seqP [(0, 2, s "superpiano" # n "c")]

This fails because p "looper" starts a pattern with the id "looper", but the qtrigger is looking up a pattern with the id ""looper"". We need to update the trigger functions and search the rest of the codebase for any other functions with the same problem (by finding all the Show instances and seeing if they're used as pattern ids).

@matthewkaney
Copy link
Collaborator Author

(Thanks to @thgrund for pointing this out by the way!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant