Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line numbers broken #778

Closed
felixroos opened this issue Nov 2, 2023 · 5 comments · Fixed by #781
Closed

line numbers broken #778

felixroos opened this issue Nov 2, 2023 · 5 comments · Fixed by #781

Comments

@felixroos
Copy link
Collaborator

probably since #773 the line numbers cannot be toggled on anymore

@Dsm0
Copy link
Contributor

Dsm0 commented Nov 2, 2023

Drat... my apologies
I'm not encountering this issue locally on chrome or firefox, but am on the site.
I'll try to look into it

@felixroos
Copy link
Collaborator Author

Drat... my apologies I'm not encountering this issue locally on chrome or firefox, but am on the site. I'll try to look into it

no problem, not even sure it was your PR, as I merged a bunch of other ones too

@Dsm0
Copy link
Contributor

Dsm0 commented Nov 2, 2023

@felixroos have you been able to observe the issue occurring on a locally run instance? I have no clue what it could be

@felixroos
Copy link
Collaborator Author

@felixroos have you been able to observe the issue occurring on a locally run instance? I have no clue what it could be

i can reproduce it locally when i build the site for production using pnpm build && pnpm preview. But not sure what it is, can look more closely tomorrow

@felixroos
Copy link
Collaborator Author

@Dsm0 I found the issue, it was not at all related to your PR, sorry for the blame :P It was just a style bug that popped up after updating the site generator, fyi more info here: #781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants