Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How's a visitor to download? #302

Closed
twMat opened this issue Mar 29, 2023 · 4 comments
Closed

How's a visitor to download? #302

twMat opened this issue Mar 29, 2023 · 4 comments

Comments

@twMat
Copy link

twMat commented Mar 29, 2023

I don't know if it is solvable but it is nonetheless an issue:

How is a visitor to save/download a copy of the Tiddlyhosted TW? The browser command doesn't work but clicking the TW save button also doesn't work. For myself, you taught me the trick to add /download to the URL, but a visitor can't be expected to know or use this.

...or is this a TW issue, not a TH issue?

@simonbaird
Copy link
Collaborator

simonbaird commented Apr 10, 2023

If you (the TiddlyWiki author) want to make it easy for someone to download, there are several ways you can provide a download link. See here for a few examples.

I'm not sure what the ideal solution is, but adding a download button would be a good starting point.

@simonbaird
Copy link
Collaborator

simonbaird commented Apr 10, 2023

It might be possible to make it so the save button falls back to a download when the user is not logged in.

Thinking about this further: TiddlyWiki checks for the PUT capability right after loading. Tiddlyhost will generally respond to indicate that a put save is possible, but it doesn't do any check about whether the user really can save, i.e. it doesn't check the user is logged in and owns the site. Perhaps it could do that check, and only respond in the affirmative if the save is truly possible. Then the save button might automatically fall back to a download.

I think the downside with that is that it would be confusing for a less experienced Tiddlyhost user who doesn't understand why the save stopped working. In this scenario they are not going to get any indication that they need to log in again to restore the expected functionality, which could be frustrating and confusing. (Maybe as a compromise for those users, it could be an advanced option, e.g. "Save should fall back to a download when user is not logged in or doesn't own the site".)

@simonbaird
Copy link
Collaborator

See also #122 which I realized is pretty much the same topic.

@simonbaird
Copy link
Collaborator

Closing this one since I don't think this is a problem Tiddlyhost wants to solve.

FWIW I'm maintaining a download button in MPTW5 now, see here.

@simonbaird simonbaird closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants