fix(android): move rejection of closing unopened window up hierarchy so it applies to TabGroup too

Author: sgtcoolguy

android/modules/ui/src/java/ti/modules/titanium/ui/WindowProxy.java

@@ -131,17 +131,6 @@ public KrollPromise<Void> open(@Kroll.argument(optional = true) Object arg)
 		return super.open(arg);
 	}
 
-	@Override
-	public KrollPromise<Void> close(@Kroll.argument(optional = true) Object arg)
-	{
-		if (!(opened || opening)) {
-			return KrollPromise.create((promise) -> {
-				promise.reject(new Throwable("Window is not open or opening, so cannot be closed."));
-			});
-		}
-		return super.close(arg);
-	}
-
 	@Override
 	protected void handleOpen(KrollDict options)
 	{

android/titanium/src/java/org/appcelerator/titanium/proxy/TiWindowProxy.java

@@ -152,9 +152,14 @@ public boolean isFocused()
 	@Kroll.method
 	public KrollPromise<Void> close(@Kroll.argument(optional = true) Object arg)
 	{
+		if (!(opened || opening)) {
+			return KrollPromise.create((promise) -> {
+				promise.reject(new Throwable("Window is not open or opening, so cannot be closed."));
+			});
+		}
+
 		// FIXME: Can we "cancel" the open() promise if it's not finished?
 		closePromise = KrollPromise.create((promise) -> {
-			// TODO: if not opened, ignore? We do this in WindowProxy subclass, but not the other two...
 			KrollDict options = null;
 			TiAnimation animation = null;