Skip to content

Commit 2a19caf

Browse files
committed
fix(android)!: remove accessor methods for properties
1 parent 508d13d commit 2a19caf

File tree

5 files changed

+0
-16
lines changed

5 files changed

+0
-16
lines changed

android/kroll-apt/src/main/resources/org/appcelerator/kroll/annotations/generator/ProxyBindingV8.cpp.fm

-6
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,6 @@ Local<FunctionTemplate> ${className}::getProxyTemplate(v8::Isolate* isolate)
232232
titanium::Proxy::getProperty,
233233
titanium::Proxy::onPropertyChanged);
234234
</#if>
235-
<#if !methods?? || !methods?keys?seq_contains(getter)>
236-
DEFINE_PROTOTYPE_METHOD_DATA(isolate, t, "${getter}", titanium::Proxy::getProperty, ${name});
237-
</#if>
238-
<#if !methods?? || !methods?keys?seq_contains(setter)>
239-
DEFINE_PROTOTYPE_METHOD_DATA(isolate, t, "${setter}", titanium::Proxy::onPropertyChanged, ${name});
240-
</#if>
241235
</@Proxy.listPropertyAccessors>
242236

243237
<#if interceptor??>

android/modules/ui/src/java/ti/modules/titanium/ui/ImageViewProxy.java

-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ public boolean getReverse()
9292
}
9393

9494
@Kroll.setProperty(runOnUiThread = true)
95-
@Kroll.method(runOnUiThread = true)
9695
public void setReverse(boolean reverse)
9796
{
9897
getImageView().setReverse(reverse);
@@ -105,7 +104,6 @@ public TiBlob toBlob()
105104
}
106105

107106
@Kroll.setProperty(runOnUiThread = true)
108-
@Kroll.method(runOnUiThread = true)
109107
public void setTintColor(String color)
110108
{
111109
getImageView().setTintColor(color);

android/modules/ui/src/java/ti/modules/titanium/ui/UIModule.java

-2
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,6 @@ public void onDisposing(KrollRuntime runtime)
414414
}
415415

416416
@Kroll.setProperty(runOnUiThread = true)
417-
@Kroll.method(runOnUiThread = true)
418417
public void setBackgroundColor(String color)
419418
{
420419
doSetBackgroundColor(color);
@@ -429,7 +428,6 @@ protected void doSetBackgroundColor(String color)
429428
}
430429

431430
@Kroll.setProperty(runOnUiThread = true)
432-
@Kroll.method(runOnUiThread = true)
433431
public void setBackgroundImage(Object image)
434432
{
435433
doSetBackgroundImage(image);

android/modules/ui/src/java/ti/modules/titanium/ui/WebViewProxy.java

-1
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ public void resume()
366366
}
367367
}
368368

369-
@Kroll.method(runOnUiThread = true)
370369
@Kroll.setProperty(runOnUiThread = true)
371370
public void setEnableZoomControls(boolean enabled)
372371
{

android/titanium/src/java/org/appcelerator/titanium/proxy/TiWindowProxy.java

-5
Original file line numberDiff line numberDiff line change
@@ -222,29 +222,24 @@ protected void releaseViewsForActivityForcedToDestroy()
222222
releaseViews();
223223
}
224224

225-
@Kroll.method(name = "setTab")
226225
@Kroll.setProperty(name = "tab")
227226
public void setTabProxy(TiViewProxy tabProxy)
228227
{
229228
setParent(tabProxy);
230229
this.tab = tabProxy;
231230
}
232-
233-
@Kroll.method(name = "getTab")
234231
@Kroll.getProperty(name = "tab")
235232
public TiViewProxy getTabProxy()
236233
{
237234
return this.tab;
238235
}
239236

240-
@Kroll.method(name = "setTabGroup")
241237
@Kroll.setProperty(name = "tabGroup")
242238
public void setTabGroupProxy(TiViewProxy tabGroupProxy)
243239
{
244240
this.tabGroup = tabGroupProxy;
245241
}
246242

247-
@Kroll.method(name = "getTabGroup")
248243
@Kroll.getProperty(name = "tabGroup")
249244
public TiViewProxy getTabGroupProxy()
250245
{

0 commit comments

Comments
 (0)