Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less restrictive snapshot test for recipes #243

Closed
EmilHvitfeldt opened this issue Dec 14, 2023 · 1 comment
Closed

Less restrictive snapshot test for recipes #243

EmilHvitfeldt opened this issue Dec 14, 2023 · 1 comment
Labels
upkeep maintenance, infrastructure, and similar

Comments

@EmilHvitfeldt
Copy link
Member

When I prepped the {recipes} release, I ended up temporarily undoing a change in an warning, because it would have otherwise stopped the release. If would be nice if we could make the hardhat test a little less fragile

tidymodels/recipes@55da6dc

corresponding {hardhat} test

expect_warning(
expect_warning(
xx2 <- forge(new, x2$blueprint),
"Novel levels found in column 'f': 'e'"
),
"There are new levels in a factor: NA"
)

@EmilHvitfeldt EmilHvitfeldt added the upkeep maintenance, infrastructure, and similar label Dec 14, 2023
@DavisVaughan
Copy link
Member

i think we should make them actual snapshot tests, rather than expect_warning() calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants