fix some issues

Author: ‘topepo’

R/arguments.R

@@ -92,7 +92,7 @@ set_mode <- function(object, mode, ...) {
 }
 
 #' @export
-set_mode.model_spec <- function(object, mode, quantile_level = NULL) {
+set_mode.model_spec <- function(object, mode, quantile_level = NULL, ...) {
   cls <- class(object)[1]
   if (rlang::is_missing(mode)) {
     spec_modes <- rlang::env_get(get_model_env(), paste0(cls, "_modes"))
@@ -115,7 +115,7 @@ set_mode.model_spec <- function(object, mode, quantile_level = NULL) {
 }
 
 #' @export
-set_mode.default <- function(object, mode) {
+set_mode.default <- function(object, mode, ...) {
   error_set_object(object, func = "set_mode")
 
   invisible(FALSE)

R/predict.R

@@ -198,15 +198,12 @@ check_pred_type <- function(object, type, ...) {
              regression = "numeric",
              classification = "class",
              "censored regression" = "time",
-             rlang::abort("`type` should be 'regression', 'censored regression', or 'classification'."))
+             "quantile regression" = "quantile",
+             cli::cli_abort("{.arg type} should be one of {.val {all_modes}}."))
+  }
+  if (!(type %in% pred_types)) {
+    cli::cli_abort("{.arg type} should be one of {.val {pred_types}}.")
   }
-  if (!(type %in% pred_types))
-    rlang::abort(
-      glue::glue(
-        "`type` should be one of: ",
-        glue_collapse(pred_types, sep = ", ", last = " and ")
-      )
-    )
 
   switch(
     type,

tests/testthat/_snaps/args_and_modes.md

@@ -60,7 +60,7 @@
       linear_reg() %>% set_mode()
     Condition
       Error in `set_mode()`:
-      ! Available modes for model type linear_reg are: "unknown" and "regression".
+      ! Available modes for model type linear_reg are: "unknown", "regression", and "quantile regression".
 
 ---
 
@@ -77,7 +77,7 @@
       linear_reg() %>% set_engine()
     Condition
       Error in `set_engine()`:
-      ! Missing engine. Possible mode/engine combinations are: regression {lm, glm, glmnet, stan, spark, keras, brulee}.
+      ! Missing engine. Possible mode/engine combinations are: quantile regression {quantreg} and regression {lm, glm, glmnet, stan, spark, keras, brulee}.
 
 ---