Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse dependency check in actions #1129

Open
topepo opened this issue Jul 5, 2024 · 2 comments
Open

reverse dependency check in actions #1129

topepo opened this issue Jul 5, 2024 · 2 comments
Labels
discussion upkeep maintenance, infrastructure, and similar

Comments

@topepo
Copy link
Member

topepo commented Jul 5, 2024

Set up a cron job GH action to run revdepcheck::revdep_check() for parsnip

@topepo topepo added discussion upkeep maintenance, infrastructure, and similar labels Jul 5, 2024
@simonpcouch
Copy link
Contributor

I think this was the best possible misspelling of dependency😝

I'm not super enthusiastic about this one. I feel that:

  • Unexpected reverse dependency breakages haven't bit me too much in the past. If I unexpectedly break something, I can wait to submit for two weeks, and if I can't wait to submit for two weeks, I would have made a moment to run revdepchecks two weeks prior.
  • In tidymodels, we tend to maintain multiple Remotes depending on each other at once, which (at least) cloud_check() has trouble with.
  • False positives: I often find, when running revdepchecks, I have to debug one or two installation issues before getting results that I believe. (CRAN seems to struggle with false positives in automated revdepchecks, too.) I think we'd end up with a lot of noise and maintenance burden that would end up being more burdensome than our existing, manual workflow.
  • Speed: with the publicly available runners, we only have access to 4 cores. For some of our packages, this would be a very long-running Action, especially in juxtaposition to the massively parallel cloud_check().

@topepo
Copy link
Member Author

topepo commented Jul 15, 2024

I think this was the best possible misspelling of dependency😝

Wow.

When we do a release, we are supposed to give revdep package maintainers 2-3 weeks to get on CRAN. That could complicate things if we are in a hurry and get caught by something unexpected.

@topepo topepo changed the title reverse decency check in actions reverse dependency check in actions Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants