-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axe_data does not remove pre$mold$extras #205
Comments
Removing according to
And I don't see |
Would the code change be similar to the others and add a new function call to set $extras to NULL: x <- replace_workflow_extras(x, NULL) or would we want to preserve $extras$offset, $extras$id or extras$case_weights. I'm not sure I fully understand the use of those roles. |
@simonpcouch should be able to confirm. But I'm pretty sure we don't need them for prediction |
The axe_data.workflow() function does not remove the mold$extras like it does for outcomes and predictors. If a column of data is set to be another role, the model will retain all of that data. Would it be OK to also remove pre$mold$extras or was it intentionally retained for predictions?
The 'outcomes' and 'predictors' are removed here.
The text was updated successfully, but these errors were encountered: