Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing eval_time through workflow_map() #140

Merged
merged 4 commits into from
Jan 23, 2024
Merged

allow passing eval_time through workflow_map() #140

merged 4 commits into from
Jan 23, 2024

Conversation

simonpcouch
Copy link
Contributor

Some refactoring that needs to happen here but this should be enough to open up workflowsets to survival.

@simonpcouch
Copy link
Contributor Author

Oh! Closes #139.

@simonpcouch simonpcouch linked an issue Jan 23, 2024 that may be closed by this pull request
workflow_map() does not allow passing eval_time #139
Closed
@simonpcouch
Copy link
Contributor Author

For now, there will be errors/warnings for each eval_time issue that occurs per workflow. This is consistent with how the package handles other forms of per-tuning-result errors (as users can vary options such that different workflows would experience different issues), so I'll leave that as-is.

@simonpcouch simonpcouch merged commit 1187448 into main Jan 23, 2024
10 checks passed
@simonpcouch simonpcouch deleted the eval-139 branch January 23, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workflow_map() does not allow passing eval_time
1 participant
@simonpcouch