-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter, slice, arrange dropping attributes #1064
Comments
@romainfrancois can we also preserve all data frame attributes? @DavisBrian do you expect |
@hadley I would not expect summarise() to keep attributes. In my mind summarise() represents different data. The other functions are more or less just subsets and orderings of the same data. Or at least that's my use case. |
In my experience, this issue often creates problems using lubridate and dplyr together, which is a thing I'm always wanting to do! |
Should be fixed the dev version |
Oops, wrong issue. |
Ah. Might have closed it too soon. So @hadley do we want to keep attributes for |
Hmmmmmmmm, for summarise I think we should be able to rely on the summary function doing the right thing. (So that might require preserving attributes in the hybrid handlers) |
Sure, but this only concerns attributes of the columns right ? |
Oh, sorry yes :/ So summarise should preserve these attributes. |
I'm not sure if this is by design or a bug.
I would expect that since filter and slice are subsets of the original data frame that all of the original data frames attributes would go along with it. Similarly since arrange is a reordering of the data I would expect it to keep attributes, much like group_by and select do.
The text was updated successfully, but these errors were encountered: