Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to switch between by and keyby #85

Closed
hadley opened this issue Jul 3, 2019 · 0 comments
Closed

Make it possible to switch between by and keyby #85

hadley opened this issue Jul 3, 2019 · 0 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Jul 3, 2019

From @jangorecki:

Moreover doing keyby vs by adds an overhead, thus by should be preferred as default. Difference is not anything big (AFAIR up to 15-25%), and might depend on GForce being utilised. I understand that keyby would be consistent with how dplyr orders grouping results, but many (or even most?) of dplyr backends are not maintaining any specific order of results so that shouldn't be big deal.
@hadley hadley added the feature a feature request or enhancement label Jul 3, 2019
hadley referenced this issue Jul 3, 2019
@hadley
More considered key/group set
7491a13 
* Eliminate key_by() in favour of key_by argument to lazy_dt()

* `group_by()` now uses `keyby` instead of `by` to preserve dplyr group ordering semantics.

cc @MichaelChirico
@psanker psanker mentioned this issue Dec 8, 2019
Merged
@hadley hadley closed this as completed in d533983 Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadley