add regression tests

Author: clauswilke

tests/figs/guides/one-combined-colorbar-for-colour-and-fill-aesthetics.svg

@@ -205,3 +205,17 @@ test_that("colorbar can be styled", {
         )
     )
 })
+
+test_that("guides can handle multiple aesthetics for one scale", {
+  df <- data.frame(x = c(1, 2, 3),
+                   y = c(6, 5, 7))
+
+  p <- ggplot(df, aes(x, y, color = x, fill = y)) +
+    geom_point(shape = 21, size = 3, stroke = 2) +
+    scale_colour_viridis_c(
+      name = "value",
+      option = "B", aesthetics = c("colour", "fill")
+    )
+
+  expect_doppelganger("one combined colorbar for colour and fill aesthetics", p)
+})

tests/testthat/test-guides.R

@@ -209,7 +209,7 @@ test_that("Size and alpha scales throw appropriate warnings for factors", {
   )
   # There should be no warnings for ordered factors
   expect_warning(ggplot_build(p + geom_point(aes(size = o))), NA)
-  expect_warning(ggplot_build(p + geom_point(aes(alpha = o))), NA) 
+  expect_warning(ggplot_build(p + geom_point(aes(alpha = o))), NA)
 })
 
 test_that("Shape scale throws appropriate warnings for factors", {
@@ -230,3 +230,44 @@ test_that("Shape scale throws appropriate warnings for factors", {
     "Using shapes for an ordinal variable is not advised"
   )
 })
+
+test_that("Aesthetics can be set independently of scale name", {
+  df <- data.frame(
+    x = LETTERS[1:3],
+    y = LETTERS[4:6]
+  )
+  p <- ggplot(df, aes(x, y, fill = y)) +
+    scale_colour_manual(values = c("red", "green", "blue"), aesthetics = "fill")
+
+  expect_equal(layer_data(p)$fill, c("red", "green", "blue"))
+})
+
+test_that("Multiple aesthetics can be set with one function call", {
+  df <- data.frame(
+    x = LETTERS[1:3],
+    y = LETTERS[4:6]
+  )
+  p <- ggplot(df, aes(x, y, colour = x, fill = y)) +
+    scale_colour_manual(
+      values = c("grey20", "grey40", "grey60", "red", "green", "blue"),
+      aesthetics = c("colour", "fill")
+    )
+
+  expect_equal(layer_data(p)$colour, c("grey20", "grey40", "grey60"))
+  expect_equal(layer_data(p)$fill, c("red", "green", "blue"))
+
+  # color order is determined by data order, and breaks are combined where possible
+  df <- data.frame(
+    x = LETTERS[1:3],
+    y = LETTERS[2:4]
+  )
+  p <- ggplot(df, aes(x, y, colour = x, fill = y)) +
+    scale_colour_manual(
+      values = c("cyan", "red", "green", "blue"),
+      aesthetics = c("fill", "colour")
+    )
+
+  expect_equal(layer_data(p)$colour, c("cyan", "red", "green"))
+  expect_equal(layer_data(p)$fill, c("red", "green", "blue"))
+})
+