Skip to content

Commit e2bdf85

Browse files
authored
ensure that draw_axis() works with element_text() subclasses (#3381)
1 parent 1ae034e commit e2bdf85

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

R/guides-axis.r

+5-4
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ draw_axis <- function(break_positions, break_labels, axis_position, theme,
3535

3636
# override label element parameters for rotation
3737
if (inherits(label_element, "element_text")) {
38-
label_element <- merge_element(
39-
axis_label_element_overrides(axis_position, angle),
40-
label_element
41-
)
38+
label_overrides <- axis_label_element_overrides(axis_position, angle)
39+
# label_overrides is always an element_text(), but in order for the merge to
40+
# keep the new class, the override must also have the new class
41+
class(label_overrides) <- class(label_element)
42+
label_element <- merge_element(label_overrides, label_element)
4243
}
4344

4445
# conditionally set parameters that depend on axis orientation

0 commit comments

Comments
 (0)