Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting up fortify() methods for adoption? #5469

Closed
teunbrand opened this issue Oct 11, 2023 · 1 comment · Fixed by #6218
Closed

Putting up fortify() methods for adoption? #5469

teunbrand opened this issue Oct 11, 2023 · 1 comment · Fixed by #6218

Comments

@teunbrand
Copy link
Collaborator

Currently, ggplot2 hosts some fortify() methods for objects from packages that do not come with the standard R distribution.
Examples of these include the fortify methods that live in fortify-spatial.R, fortify-multcomp.R and fortify-map.R.
To my understanding, these methods exist in ggplot2 because before the advent of extension packages, these had to live in ggplot2. However, ggplot2 has become highly extensible now, which means that specialised functionality could live elsewhere.
Therefore, it might be worth exploring whether we should put these methods up for adoption into extension packages.

It might be a good idea to include @terrytangyuan in the conversation for his thoughts and maybe probe if {ggfortify} has any interest in hosting these methods.

@terrytangyuan
Copy link

Thanks for the mention. Those fortify methods look suitable in {ggfortify} if their implementations do not involve using any {ggplot2} internal methods. It would be great if anyone would like to contribute these to {ggfortify}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants