Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

losing tbl_df class after lmap #1051

Open
py-b opened this issue Jan 27, 2023 · 2 comments
Open

losing tbl_df class after lmap #1051

py-b opened this issue Jan 27, 2023 · 2 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@py-b
Copy link

py-b commented Jan 27, 2023

Applying lmap to a tibble now returns a simple data.frame.

I'm pretty sure the class c("tbl_df", "tbl", "data.frame") was preserved (before version 1.0?).

iris %>% tibble::as_tibble() %>% lmap(identity) %>% class()
#> [1] "data.frame"
@hadley
Copy link
Member

hadley commented Jan 27, 2023

Hmmm, it looks like I totally removed data frame support in #895 and then partially bought back support in 2ad46d5. I can't remember exactly why, but this problem of matching the input type is much harder than I originally thought when we first wrote this function.

@py-b
Copy link
Author

py-b commented Jan 28, 2023

Maybe you brought it back because the example with disjoin is very useful?

@hadley hadley added the bug an unexpected problem or unintended behavior label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants