Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider flatten_dfc() and flatten_dfr() #757

Closed
hadley opened this issue Apr 16, 2020 · 1 comment · Fixed by #912
Closed

Reconsider flatten_dfc() and flatten_dfr() #757

hadley opened this issue Apr 16, 2020 · 1 comment · Fixed by #912
Labels
bug an unexpected problem or unintended behavior flatten 🌎 vctrs ♣️

Comments

@hadley
Copy link
Member

hadley commented Apr 16, 2020

It's concerning that they both return the same results in this case:

library(purrr)

dfs <- list(c(a = 1), c(b = 2))
flatten_dfc(dfs)
#> # A tibble: 1 x 2
#>       a     b
#>   <dbl> <dbl>
#> 1     1     2
flatten_dfr(dfs)
#> # A tibble: 1 x 2
#>       a     b
#>   <dbl> <dbl>
#> 1     1     2

Created on 2020-04-16 by the reprex package (v0.3.0)

@hadley hadley added bug an unexpected problem or unintended behavior flatten 🌎 vctrs ♣️ labels Aug 24, 2022
@hadley
Copy link
Member Author

hadley commented Aug 24, 2022

Should either implement with vctrs or simply deprecate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior flatten 🌎 vctrs ♣️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant