Make type.character error for NA_character_ #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Looking good! My main comment is that I think you can simplify your code a little.
Could you please also add a news bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
tests/testthat/test-modifiers.R
Outdated
|
|
||
| test_that("useful error message for vector that includes NAs", { | ||
| expect_snapshot(error = TRUE, { | ||
| type(c("a", "b", NA_character_, "c")) |
Co-authored-by: Hadley Wickham <hadley@posit.co>
|
Thanks for working on this! I hope you had fun at TDD 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546