New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance unnamed `nest()` specification warning to defunct stage #1466

Open

DavisVaughan opened this issue Jan 13, 2023 · 0 comments

Labels

breaking change ☠️ nesting 🐦

Member

DavisVaughan commented Jan 13, 2023

i.e. this warning from here

Lines 146 to 149 in 71ec2d6

    
           cli::cli_warn(c( 
        
             "All elements of `...` must be named.", 
        
             i = "Did you want `{(.key)} = {cols_fixed_label}`?" 
        
           ))

nest(mtcars, -vs)
#> Warning: All elements of `...` must be named.
#> ℹ Did you want `data = -vs`?
#> # A tibble: 2 × 2
#>      vs data              
#>   <dbl> <list>            
#> 1     0 <tibble [18 × 10]>
#> 2     1 <tibble [14 × 10]>

This has been warning on every call since tidyr 1.0.0 in 2019, so we should be able to move this to defunct.

Last time we tried this (#1464), 5 packages failed. So we'd need to send them PRs to update.

cubble
highcharter
HTSSIP
T2Qv
unpivotr

DavisVaughan added breaking change ☠️ nesting 🐦 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment