Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error: Extension unavailable, ping failed #175

Closed
Tbaut opened this issue Oct 31, 2024 · 3 comments · Fixed by #180
Closed

Uncaught Error: Extension unavailable, ping failed #175

Tbaut opened this issue Oct 31, 2024 · 3 comments · Fixed by #180

Comments

@Tbaut
Copy link

Tbaut commented Oct 31, 2024

I caught this while testing all the scenarii.
When you click on connect for pjs-extension for instance, but the user rejects the auth request, the whole dot-connect modal crashes/disappears and unhandled exception is fired.

image

Instead, it'd be great to catch the error, show it in the console, and show the "connect" button again.

@tien
Copy link
Owner

tien commented Nov 3, 2024

@Tbaut thanks for reporting the issue. I've tried to reproduce this and was unable to get the modal to crash. Can you share a reproduction link if possible?

@Tbaut
Copy link
Author

Tbaut commented Nov 4, 2024

My bad, it's not crashing when run live, it's only my test instance that is stopping abruptly, because of an uncaught error.
As for the reproduction of the uncaught error, in case this is helpful, it's happening on https://delegit.xyz for instance, when you click on "connect" for Polkadot-js, but then "reject" the connection on the popup.

@Tbaut
Copy link
Author

Tbaut commented Nov 5, 2024

Thank you so much, the latest release solved it well 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants