Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button "WEB-Dashboard" should link to configured "API-Path", not to "/admin/" #198

Open
Tqnsls opened this issue Jan 20, 2024 · 4 comments · May be fixed by #199
Open

Button "WEB-Dashboard" should link to configured "API-Path", not to "/admin/" #198

Tqnsls opened this issue Jan 20, 2024 · 4 comments · May be fixed by #199
Assignees
@tien
Labels
bug Something isn't working

Comments

@Tqnsls
Copy link

Tqnsls commented Jan 20, 2024

Describe the bug
The button "WEB-Dahsboard" in the upper-ride menu in the app links to /admin/ although I configured a different "API-Path" for my pihole.

To Reproduce
Steps to reproduce the behaviour:

  1. Configure an "API-Path" to anything different than "/admin", e.g. "pihole-api.php"
  2. Open the "WEB-Dashboard"

Expected behaviour
The button should link to the "API-Path" there should be a further field for the URL in the configuration part for the pihole.

Smartphone (please complete the following information):
@Tqnsls Tqnsls added the bug Something isn't working label Jan 20, 2024
@Tqnsls Tqnsls changed the title [BUG] Button "WEB-Dashboard" should link to configured "API-Path", not to "/admin/" Jan 20, 2024
@tien tien linked a pull request Jan 22, 2024 that will close this issue
Open
@tien
Copy link
Owner

tien commented Jan 23, 2024 •
edited
Loading

Hey @Tqnsls can you see if this build here solves the issue for you? https://github.com/tien/pi-hole-connect/actions/runs/7618923092?pr=199

The build should be in the artifact zip which you can download.

@Tqnsls
Copy link
Author

Tqnsls commented Jan 23, 2024

Hi @tien, the pull now changes the custom path to "/". Now for any web servers that have no Rewrite / ProxyPass to the custom path, this does still not work.
What I had in mind was a new field or maybe a regex to take the custom entered path and e.g. remove the "/api.php".

@tien
Copy link
Owner

tien commented Feb 18, 2024

Hey @Tqnsls, sorry for not getting back on this. I'll probably have this done as part of the upcoming v6 support/

@Tqnsls
Copy link
Author

Tqnsls commented Feb 18, 2024

Sounds great, no need to hurry! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tien tien

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect admin URL with custom API path tien/pi-hole-connect
2 participants
@tien @Tqnsls