Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDiscoverProvider leads to wrong result #2920

Open
akesser opened this issue Oct 9, 2023 · 0 comments · May be fixed by #2923
Open

AutoDiscoverProvider leads to wrong result #2920

akesser opened this issue Oct 9, 2023 · 0 comments · May be fixed by #2923

Comments

@akesser
Copy link

akesser commented Oct 9, 2023

The code in pkg/controller/utils/discovery.go in the function autodetectFromGroup results in wrong results.

We run tigera-operater on EKS and the installation uses: kubernetesProvider: EKS but we observed the following error:

Installation spec.kubernetesProvider 'EKS' does not match auto-detected value 'GKE'

We found out that the code

if g.Name == "networking.gke.io" {
	// Running on GKE.
	return operatorv1.ProviderGKE, nil
}

is responsible for our Problem. We are using fqdnnetworkpolicies in the group networking.gke.io and therefore autodetectFromGroup results in the wrong value.

Expected Behavior

Tigera Operator should detect the correct cluster type

Current Behavior

tigera-operator blives to be in GKE and complains about the kubernetesProvider: EKS setting in the installation

Possible Solution

Allow to disable AutoDiscoverProvider by using a ENV variable or a argument for the operator

Steps to Reproduce (for bugs)

  1. install fqdnnetworkpolicies.networking.gke.io on a EKS cluster
  2. start tigera-operator

Context

Your Environment

  • Operating System and version:
  • Link to your project (optional):
@akesser akesser changed the title AutoDiscoverProvider lead to wrong result AutoDiscoverProvider leads to wrong result Oct 10, 2023
@akesser akesser linked a pull request Oct 11, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant