Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show abandoned tag #209

Closed
wants to merge 1 commit into from
Closed

Conversation

RhysLees
Copy link
Contributor

@RhysLees RhysLees commented May 6, 2022

This PR will show a tag on the index if the package is believed to be abandoned.

image
image

Closes #63

@marcusmoore
Copy link
Contributor

Thanks for the PR @RhysLees. I'll check it out later this week 😄

@marcusmoore
Copy link
Contributor

(This is still on my radar)

@marcusmoore marcusmoore self-assigned this May 17, 2022
@marcusmoore
Copy link
Contributor

This obviously fell off of my radar...

This seems to show the possibly abandoned tag on most packages. I believe it is happening because $composer_latest and $packagistData are passed to isPossiblyAbandoned() with null and []. Copying the code that populates those variables from PackageDetailResource would probably get around that issue.

But that exposes another issue: the code that populates those variables is calling Packagist::make($package->composer_name) which calls fetchData which pings packagist. This call is cached but it looks like it is only for five seconds (which should probably be addressed). Because of this, navigating the index becomes really slow.

Overall, I think addressing the issue above should come before this work.

Thank you for the contribution but I'm going to close this for now and possible re-visit it in the future but let me know you have an idea for a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show if package is abandoned on the All Packages page
2 participants