-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow per-target JEMALLOC_OVERRIDE
env
#90
Comments
Can you explain more on what "failures" you met? |
this can failure when cross compiling a binary incompatible scene like from Darwin to Linux while they uses completely different executable formats. As there is only one JEMALLOC_OVERRIDE can be defined, the linker will eventually complains about unsupported binary format |
I don't get it. You should cross compile for one target at a time, right? So why not just specify the correct |
rustc itself is using jemalllc-sys, while it compiles build and host toolchain at same time when |
I see. Would you like to send a PR? |
While cross-compiling, setting
JEMALLOC_OVERRIDE
could cause failures due to incompatibilities between build and host platforms.A better solution would be something like openssl-sys/build/find_normal.rs#L14 which has implementation at openssl-sys/build/main.rs#L41, which allows env definitions as a form of
<TARGET_TRIPLE>_ENV
(e.g.AARCH64_APPLE_DARWIN_MYENV
The text was updated successfully, but these errors were encountered: