Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running minitrace as a standalone project? #229

Closed
tisonkun opened this issue Jul 3, 2024 · 7 comments
Closed

Running minitrace as a standalone project? #229

tisonkun opened this issue Jul 3, 2024 · 7 comments

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Jul 3, 2024

Hi guys!

Recently, I had a talk with @andylokandy (one of minitrace's maintainers) about the growth and future of this project. Basically, the minitrace subproject within TiKV owns these repos:

While minitrace-rust has updated 2 days ago, the last time minitrace-go got updated should go back to 2 years ago. In the recent months, minitrace grows a series of new adoptions, like:

  • foyer
  • Databend
  • Apache OpenDAL
  • ConsDB
  • ...

However, TiDB and TiKV itself doesn't use minitrace, which can cause users feeling strange why it's under the TiKV organization. And also, @andylokandy and our active contributor @Xuanwo, found it more motivated to run minitrace as a standalone project.

I believe it would be a net win to let minitrace go and form its community, while we still record the history that it's incubated from within the TiKV organization. In this way, we can see that TiKV as a graduated project in CNCF can spawn new vivid OSS project, and minitrace can use its own branding for operating and growth.

For the policy and process part, I consult one of the TOC member in CNCF and it's said that as long as the commitee of TiKV, defined in the GOVERNANCE file, reach a consensus to split minitrace from its organization, it should be fine.

For what exactly to be done:

  1. Create a separated organization, perhaps named minitrace.
  2. Move minitrace-rust and minitrace-go to that organization.
  3. Record a consensus with a vote that this project is now a standalone OSS project, not part of TiKV or the CNCF.

What do you think?

For minitrace maintainers: @andylokandy @zhongzc

For TiKV committee: @fredchenbj @lidaobing @BusyJay @sunxiaoguang @siddontang @winkyao @zhangjinpeng87 @ngaut @c4pt0r

@BusyJay
Copy link
Member

BusyJay commented Jul 4, 2024

However, TiDB and TiKV itself doesn't use minitrace, which can cause users feeling strange why it's under the TiKV organization.

Ownership is not defined by usage, isn't it?

I can't represent other committee, but I will vote against this proposal as it doesn't make any sense to me. If as TiKV committers/maintainers and don't feel comfortable contribute to projects in TiKV org, or contributors don't feel comfortable to join TiKV community, I suggest to setup a new organization and fork the project.

@zhongzc
Copy link
Collaborator

zhongzc commented Jul 4, 2024

I completely understand the concerns about ownership and the potential implications for the TiKV community.

I genuinely think that forking is a practical suggestion. It provides a solution that allows us to achieve nearly the goal mentioned by @tisonkun without imposing on the TiKV committee’s preferences. However, forking might not be the most favorable path in terms of optics and could create unnecessary fragmentation.

I advocate for a more lenient approach from the TiKV community. If separating minitrace does not impact the core operations or goals of TiKV, a graceful transition might be more conducive for both communities. Minitrace can flourish with its own identity, while TiKV can showcase its ability to incubate and nurture successful projects.

While I understand and respect @BusyJay’s stance, I believe that allowing minitrace to stand on its own could be a win-win scenario. It would present a more unified and professional front, both internally and to the broader open-source community.

@kevin-wangzefeng
Copy link

For the policy and process part, I consult one of the TOC member in CNCF and it's said that as long as the commitee of TiKV, defined in the GOVERNANCE file, reach a consensus to split minitrace from its organization, it should be fine.

It’s essential to emphasize that consensus-building is a crucial but also initial step. Additionally, I'd recommend verifying with CNCF whether there are any implications related to branding, as there may be a potential brand transfer. While I’m not an expert on branding, my understanding is that “Minitrace” is currently a TiKV associated brand.

As a CNCF TOC member, I’m happy to answer questions if any of you need help on understanding CNCF rules and guidelines. However, I don’t have a preference for a specific path. Typically, the TOC doesn’t directly intervene in project governance decisions. Instead, it’s essential to consider how the TiKV community prefers to handle this transition first.

@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 8, 2024

I genuinely think that forking is a practical suggestion. It provides a solution that allows us to achieve nearly the goal mentioned by @tisonkun without imposing on the TiKV committee’s preferences. However, forking might not be the most favorable path in terms of optics and could create unnecessary fragmentation.

Yes. Forking is possible and can be done independently.

However, since it's one of the major maintainers' suggestion, I'm trying to find a way to reduce the fragmentation, i.e., the new "foo-trace" build its own branding from scratch, the minitrace project being unmaintained, which is a lose-lose.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 16, 2024

The fork has been created: https://github.com/fastracelabs/fastrace. We are beginning the migration from minitrace to fastrace. It's unfortunate that the community is splitting like this. We hope the tikv community continues to maintain minitrace effectively as well.

@andylokandy
Copy link
Collaborator

I'm closing this issue since we have come to this conclusion: fork with name fastrace, and the minitrace maintainer will continue development there. Thank you all for supporting us all the time!

@breezewish
Copy link
Member

Currently user needs a manual click in order to reach fastrace from minitrace. How about just moving the repository so that GitHub will automatically do the redirection for users? This seems to be a broader adopted way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants