Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise tso time decoding. #1241

Closed
winkyao opened this issue Sep 11, 2018 · 2 comments
Closed

More precise tso time decoding. #1241

winkyao opened this issue Sep 11, 2018 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@winkyao
Copy link

winkyao commented Sep 11, 2018

https://github.com/pingcap/pd/blob/master/pdctl/command/tso_command.go#L51

physicalTime := time.Unix(int64(physical/1000), 0)

Should change to

physicalTime := time.Unix(int64(physical/1000), physical%1000 * 1e6)
@disksing
Copy link
Contributor

PTAL @nolouch

@disksing disksing added type/enhancement The issue or PR belongs to an enhancement. area/pdctl labels Sep 11, 2018
@rleungx
Copy link
Member

rleungx commented Sep 12, 2018

Closed via #1242.

@rleungx rleungx closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@winkyao @disksing @rleungx