Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd to v3.5.x #3877

Closed
disksing opened this issue Jul 16, 2021 · 1 comment · Fixed by #8441
Closed

Update etcd to v3.5.x #3877

disksing opened this issue Jul 16, 2021 · 1 comment · Fixed by #8441
Assignees
Labels
status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.

Comments

@disksing
Copy link
Contributor

disksing commented Jul 16, 2021

Development Task

etcd v3.5.0 is the latest stable release version which is also go mod compatible version when used as a library. As there are other applications and libraries using pd (or pd client) as a library, we should upgrade etcd to v3.5.0 to make it more community-friendly.

There was an attempt before #3873. But we cannot merge it because upgrading the tidb-dashboard's etcd will break the PD of the release branches since the PDs of the different branches all depend on the release branch's tidb-dashboard.

Therefore, before upgrading etcd, we need to resolve the dependency between pd and tidb-dashboard. Specifically, create separate go mods for pd and pd-server, so that only pd-server will depend on tidb-dashboard and we can upgrade pd without upgrading tidb-dashboard.

@disksing disksing added type/enhancement The issue or PR belongs to an enhancement. status/TODO The issue will be done in the future. labels Jul 16, 2021
@disksing disksing self-assigned this Jul 16, 2021
@maoueh
Copy link

maoueh commented Aug 12, 2021

I would like to see how this can be pushed faster. Right now depending on tikv client-go is really a pain because for example, we are completely unable to perform a go mod tidy in our project due to problem with the infamous etcd library dependencies.

It would be more than welcome that this is done sooner than later. Willing to help if some hands are required.

@nolouch nolouch changed the title Update etcd to v3.5.0 Update etcd to v3.5.x Oct 23, 2023
@ti-chi-bot ti-chi-bot bot closed this as completed in cc2900c Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants