Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/http: encapsulate rule-related PD HTTP interfaces #7397

Merged
merged 3 commits into from
Nov 21, 2023
Merged

client/http: encapsulate rule-related PD HTTP interfaces #7397

merged 3 commits into from
Nov 21, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

Expand the PD HTTP interfaces to include more encapsulation, particularly focusing on the rule-related interfaces.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato
Encapsulate more PD HTTP interfaces
d9e988c 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/api HTTP API. component/client Client logic. labels Nov 20, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2023
@JmPotato JmPotato changed the title client/http: encapsulate more PD HTTP interfaces client/http: encapsulate rule-related PD HTTP interfaces Nov 20, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #7397 (d9e988c) into master (89c8374) will decrease coverage by 0.09%.
Report is 2 commits behind head on master.
The diff coverage is 65.62%.

❗ Current head d9e988c differs from pull request most recent head c10956a. Consider uploading reports for the commit c10956a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7397      +/-   ##
==========================================
- Coverage   74.26%   74.18%   -0.09%     
==========================================
  Files         451      451              
  Lines       49119    49157      +38     
==========================================
- Hits        36480    36466      -14     
- Misses       9424     9457      +33     
- Partials     3215     3234      +19
Flag Coverage Δ
unittests 74.18% <65.62%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Nov 20, 2023
View reviewed changes
client/http/client.go
@@ -51,11 +52,24 @@ type Client interface {
GetHotWriteRegions(context.Context) (*StoreHotPeersInfos, error)
GetRegionStatusByKeyRange(context.Context, []byte, []byte) (*RegionStats, error)
GetStores(context.Context) (*StoresInfo, error)
/* Rule-related interfaces */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two groups of API for the placement rule, maybe we can reduce it later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after replacing the existing TiDB code, we can reduce the exposed interfaces here.

HuSharp
HuSharp approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2023
@JmPotato
Copy a new client inside WithRespHandler
cd5397a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cd5397a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

@JmPotato: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato JmPotato mentioned this pull request Nov 21, 2023
Open
7 tasks
@ti-chi-bot ti-chi-bot bot merged commit 2349f01 into tikv:master Nov 21, 2023
22 checks passed
@JmPotato JmPotato deleted the update_pd_http_client_api branch November 21, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
component/api HTTP API. component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @rleungx @HuSharp