Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: fix TestAllocIDAfterLeaderChange #7426

Merged
merged 2 commits into from
Nov 24, 2023
Merged

mcs: fix TestAllocIDAfterLeaderChange #7426

merged 2 commits into from
Nov 24, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7427.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2023
@rleungx rleungx mentioned this pull request Nov 23, 2023
Closed
@rleungx
make TestUpdateDefaultReplicaConfig stable
17c5f81 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx marked this pull request as ready for review November 24, 2023 03:32
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2023
@rleungx rleungx changed the title mcs: make TestUpdateDefaultReplicaConfig stable mcs: fix TestAllocIDAfterLeaderChange Nov 24, 2023
@rleungx
fix race
01e7080 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #7426 (01e7080) into master (9902be8) will decrease coverage by 0.20%.
Report is 1 commits behind head on master.
The diff coverage is 58.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7426      +/-   ##
==========================================
- Coverage   74.32%   74.13%   -0.20%     
==========================================
  Files         451      451              
  Lines       49387    49530     +143     
==========================================
+ Hits        36709    36719      +10     
- Misses       9417     9514      +97     
- Partials     3261     3297      +36
Flag Coverage Δ
unittests 74.13% <58.24%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 24, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 01e7080

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit eafc1ed into tikv:master Nov 24, 2023
24 of 26 checks passed
@rleungx rleungx deleted the stable-test14 branch November 24, 2023 07:38
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: fix TestAllocIDAfterLeaderChange (tikv#7426)
dcb142b 
close tikv#7427

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestAllocIDAfterLeaderChange is datarace
3 participants
@rleungx @lhy1024 @CabinfeverB