Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: update tso metrics in micro service #7873

Merged
merged 3 commits into from
Mar 6, 2024
Merged

metrics: update tso metrics in micro service #7873

merged 3 commits into from
Mar 6, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #5839

What is changed and how does it work?

Check List

Tests

  • Unit test

img_v3_028n_82758020-2503-43e7-9ad5-08a6faad602g
image

Release note

None.

@lhy1024
metrics: update tso metrics in micro service
8ca3c31 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

Merging #7873 (a750fe8) into master (6a45734) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7873      +/-   ##
==========================================
+ Coverage   73.53%   73.60%   +0.06%     
==========================================
  Files         433      433              
  Lines       47965    47965              
==========================================
+ Hits        35272    35303      +31     
+ Misses       9657     9634      -23     
+ Partials     3036     3028       -8
Flag Coverage Δ
unittests 73.60% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2024
@lhy1024
update cluster
ac89811 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 6, 2024

/retest

@rleungx
Copy link
Member

rleungx commented Mar 6, 2024

/test build

@HuSharp
Copy link
Member

HuSharp commented Mar 6, 2024

image

@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 6, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: a750fe8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 6, 2024

/test build

1 similar comment
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 6, 2024

/test build

@ti-chi-bot ti-chi-bot bot merged commit e72d49b into tikv:master Mar 6, 2024
25 of 26 checks passed
@lhy1024 lhy1024 deleted the metrics3 branch March 6, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate scheduling into an independent service
5 participants
@lhy1024 @rleungx @HuSharp @nolouch @CabinfeverB