Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About encryption #340

Closed
acelyc111 opened this issue Jul 6, 2023 · 3 comments
Closed

About encryption #340

acelyc111 opened this issue Jul 6, 2023 · 3 comments

Comments

@acelyc111
Copy link

Hi,
I found tikv/rocksdb has enhanced the encryption feature than facebook/rocksdb, is there a plan to submmit the related patches to facebook/rocksdb?
I'm developing the apache/incubator-pegasus project which is using rocksdb as the storage engine, researching encryption feature.
Thanks!

@tabokie
Copy link
Member

tabokie commented Jul 6, 2023

Hi, we don't have the bandwidth right now to prioritize syncing with upstream. In addition, the changes surrounding encryption are mostly plugins, they don't interact with core RocksDB functionality.

You are welcome to use/cherry-pick our code if you are interested in the features we added. I have already aggregated them into one PR: #279.

@acelyc111
Copy link
Author

@tabokie Thanks for your information, it's very helpful!

@acelyc111
Copy link
Author

@tabokie I've implemented a RocksDB plugin according to the tikv/rocksdb encryption implementation. The main difference is the encryption key is stored at the file header instead of an external file.

https://github.com/pegasus-kv/encfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants