Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/TODO: Check each commit with sanitizer #76

Open
huachaohuang opened this issue Jun 24, 2017 · 3 comments
Open

CI/TODO: Check each commit with sanitizer #76

huachaohuang opened this issue Jun 24, 2017 · 3 comments
Assignees
@huachaohuang

Comments

@huachaohuang
Copy link

Since this repo contains a lot of unsafe code, I suggest to check each commit with valgrind.

Note: valgrind shows some memory leaks / corruption on master branch, I will try to fix that later.
@huachaohuang huachaohuang self-assigned this Jun 24, 2017
@siddontang
Copy link

Hi @huachaohuang

Seem we can use sanitizer now. See rust-lang/rfcs#670

@huachaohuang
Copy link
Author

Looks good to me, when can we use it?

@siddontang
Copy link

@huachaohuang

You can try it ASAP.

@andelf andelf self-assigned this Jun 26, 2017
@andelf andelf changed the title please check each commit with valgrind CI/TODO: Check each commit with sanitizer Jun 26, 2017
@andelf andelf mentioned this issue Jun 26, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huachaohuang huachaohuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andelf @siddontang @huachaohuang