-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatible issues between async commit and green GC #82
Comments
It's a blocker for enabling async apply by default. Maybe not a blocker for async commit GA. |
For ScanLock and PhysicalScanLock requests, it should update the max_ts, check the memory lock, and finally read the raftkv or the rocksdb. |
As for async apply prewrite, can we let TiKV simply return error for green gc requests if async apply prewrite is enabled? |
There is another corner case that green GC doesn't solve now.. tikv/tikv#8184 (comment) |
Ah.. yes.. and
I notice that this is not a good idea considering the case that TiKV's config is changed and restarted. Recently Jay discussed with me about a new idea that maybe we can use resolved_ts to determine if there's any lock before safepoint that needs to be resolved. Since resolved_ts will also be used by follower stale read, it may be an always-running service, instead of running only if needed by CDC. I think this is a possible substitution to green gc, but sounds hard to deliver it in 5.0 GA. |
The text was updated successfully, but these errors were encountered: