Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qunit tests do not run under phantom.js #6

Open
lukemelia opened this issue May 30, 2013 · 5 comments
Open

Qunit tests do not run under phantom.js #6

lukemelia opened this issue May 30, 2013 · 5 comments

Comments

@lukemelia
Copy link
Collaborator

Phantom.js is currently not capable of appending iframes with data URI src attributes.

@cyril-sf
Copy link
Contributor

PhantomJS relies on QtWebkit which doesn't seem to support the dataURI protocol

http://stackoverflow.com/questions/10854028/qtwebkit-qwebview-the-data-uri-protocol-not-supported

@hjdivad
Copy link
Collaborator

hjdivad commented Jun 18, 2013

polyglot works around the dataURI issue, but there are a couple of others (eg lack of support for Function.prototype.bind, something about MessageChannel.js).

@stefanpenner
Copy link
Contributor

@hjdivad the bind polyfil may do the trick c/d?

@hjdivad
Copy link
Collaborator

hjdivad commented Jun 18, 2013

@stefanpenner confirm, and we need it anyway for ie8.

@hjdivad
Copy link
Collaborator

hjdivad commented Jul 19, 2013

Several things we need to fix to get phantom working.

  • add postMessage to window.constructor instead of Window (in phantom window.constructor is a DOMWindowConstructor rather than a Window)
  • currently our calls to postMessage generate TypeErrors. It may be the case that we simply need to omit ports when ports == []. However, it may be that we need to use the polyfill.
    • if we use the polyfill we need to either encode the oasis load message, or not attempt to erroneously decode it.
  • we need to fix all the other issues we haven't discovered yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants