New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type error on more recent TS versions #290

Closed

pzuraq opened this issue Jan 9, 2020 · 1 comment

pzuraq commented Jan 9, 2020

node_modules/router_js/dist/cjs/transition.d.ts:208:78 - error TS2677: A type predicate's type must be assignable to its parameter's type.
  Type 'typeof Transition' is not assignable to type 'Dict<unknown>'.
    Index signature is missing in type 'typeof Transition'.

208 export declare function isTransition(obj: Dict<unknown> | undefined): obj is typeof Transition;

Discovered during the most recent Glimmer-VM upgrade in Ember: emberjs/ember.js#18621

The text was updated successfully, but these errors were encountered:

Contributor

xg-wang commented Jan 12, 2020

#289 upgrades broccoli-typescript-compiler to 4.2.0, should fix the issue in ember.

stefanpenner closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment