lint: resolve clang-tidy errors

Author: XuehaiPan

.clang-tidy

@@ -1,9 +1,10 @@
 ---
 InheritParentConfig: true
+ExtraArgs: ['-v']
 FormatStyle: file
 UseColor: true
 WarningsAsErrors: '*'
-HeaderFilterRegex: '^(?!.*(3rdparty|build)).*$'
+ExcludeHeaderFilterRegex: '^(3rdparty|tvm)/.*$'
 
 # NOTE: there must be no spaces before the '-', so put the comma last.
 Checks: >-

src/layout/utils.cc

@@ -134,7 +134,7 @@ Array<IterSplitExpr> DivideUnusedIterators(const Array<PrimExpr> &exprs,
   for (const IterVar &iter : input_iters) {
     IterMark iv_mark;
     for (const IterMark &mark : collector.visited_) {
-      if (mark->source.as<Var>()->same_as(iter->var)) {
+      if (mark->source.as<Var>()->same_as(iter->var)) { // NOLINT(*)
         iv_mark = mark;
         break;
       }

src/runtime/runtime.cc

@@ -20,7 +20,7 @@ template <typename T> static std::string ArrayToStr(const T *ptr, size_t n) {
   for (size_t i = 0; i < n; i++) {
     if (i > 0)
       ss << ", ";
-    ss << ptr[i];
+    ss << ptr[i]; // NOLINT(clang-analyzer-security.ArrayBound)
   }
   ss << "]";
   return ss.str();

src/target/codegen_webgpu.cc

@@ -218,7 +218,7 @@ CodeGenTileLangWebGPU::AddFunction(const PrimFunc &f, bool skip_readonly_decl) {
   this->decl_stream << "\nstruct " << type_pod_args << " {\n";
 
   for (size_t i = 0; i < pod_args.size(); ++i) {
-    Var v = pod_args[i];
+    const Var &v = pod_args[i];
     ICHECK(!v.dtype().is_handle());
     std::string vid = AllocVarID(v.get());
 

src/transform/layout_inference.cc

@@ -131,13 +131,13 @@ class BufferUseDefCollector : public IRVisitorWithAnalyzer {
           ICHECK(dst_layout_opt.has_value())
               << "Failed to cast layout to Fragment for buffer " << buffer
               << ", layout type is " << layout->GetTypeKey();
-          auto dst_layout = dst_layout_opt.value();
+          const auto &dst_layout = dst_layout_opt.value();
           auto src_layout_opt = layout_map[buffer].as<Fragment>();
           ICHECK(src_layout_opt.has_value())
               << "Failed to cast layout_map[buffer] to Fragment for buffer "
               << buffer << ", layout type is "
               << layout_map[buffer]->GetTypeKey();
-          auto src_layout = src_layout_opt.value();
+          const auto &src_layout = src_layout_opt.value();
           ICHECK(dst_layout->InputDim() == src_layout->InputDim());
           Array<PrimExpr> indices;
           indices.reserve(dst_layout->InputDim());
@@ -398,7 +398,7 @@ class BufferUseDefCollector : public IRVisitorWithAnalyzer {
                       << call->args[1]->GetTypeKey();
         return std::nullopt;
       }
-      auto var = var_opt.value();
+      const auto &var = var_opt.value();
       return buffer_data_to_buffer_[var];
     } else if (call->op.same_as(RegionOp::Get())) {
       return call->args[0].as<BufferLoadNode>()->buffer;

src/transform/layout_reducer.cc

@@ -209,7 +209,7 @@ class ReducerLayoutAnnotator : public IRMutatorWithAnalyzer {
 
         auto opt_buffer = var_to_buffer_.Get(reducer_var);
         ICHECK(opt_buffer);
-        auto buffer = opt_buffer.value();
+        const auto &buffer = opt_buffer.value();
         Fragment f;
         if (info->rep == ReducerRepType::ALL) {
           f = Fragment(buffer->shape, {}, ReplicationPlaceholder(),

src/transform/lower_thread_allreduce.cc

@@ -496,8 +496,9 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
       if (reduce_extent == 1) {
         // special case, no reduction is needed.
         std::vector<Stmt> stores;
+        stores.reserve(size);
         for (size_t i = 0; i < size; ++i) {
-          stores.push_back(BufferStore(buffers[i], values[i], {0}));
+          stores.emplace_back(BufferStore(buffers[i], values[i], {0}));
         }
         return SeqStmt::Flatten(stores);
       }
@@ -604,7 +605,7 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
       // Load reduction values, no synchronization needed.
       Array<PrimExpr> a, b;
       for (int i = 0; i < n_buffers; ++i) {
-        Buffer shared_buf = shared_bufs[i];
+        const Buffer &shared_buf = shared_bufs[i];
         BufferLoad val(shared_buf, zero_indices);
         ICHECK_EQ(val->dtype, dtypes[i]);
         a.push_back(val);
@@ -623,7 +624,7 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
         // branch with a warp sync call inside.
         PrimExpr other = WarpShuffle(builtin::tvm_warp_shuffle_down(),
                                      mask_buffer, val, offset);
-        Buffer local_buf = local_bufs[i];
+        const Buffer &local_buf = local_bufs[i];
         Stmt s = BufferStore(local_buf, other, zero_indices);
         seq->push_back(s);
 
@@ -639,7 +640,7 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
       std::vector<Stmt> stores;
       stores.reserve(n_buffers);
       for (int i = 0; i < n_buffers; ++i) {
-        Buffer buf = shared_bufs[i];
+        const Buffer &buf = shared_bufs[i];
         stores.push_back(BufferStore(buf, ret[i], zero_indices));
       }
 

src/transform/make_packed_api.cc

@@ -477,7 +477,7 @@ tvm::transform::Pass MakePackedAPI() {
     Map<GlobalVar, String> packed_func_methods;
     for (const auto &[gvar, base_func] : mod->functions) {
       if (auto opt = base_func.as<PrimFunc>()) {
-        auto prim_func = opt.value();
+        const auto &prim_func = opt.value();
         if (auto global_symbol = RequiresPackedAPI(prim_func)) {
           packed_func_methods.Set(gvar, global_symbol.value());
         }

src/transform/storage_access.cc

@@ -209,7 +209,7 @@ void TileLangStorageAccessVisitor::VisitStmt_(const ForNode *op) {
 bool IsThreadInvariant(const PrimExpr &cond) {
   if (auto call = cond.as<CallNode>()) {
     if (auto opt_call_op = call->op.as<Op>()) {
-      auto call_op = opt_call_op.value();
+      const auto &call_op = opt_call_op.value();
       if (call_op.same_as(builtin::tvm_thread_invariant())) {
         return true;
       }

src/transform/warp_specialized_rewriter.cc

@@ -530,10 +530,11 @@ class GroupOpRewriter : public StmtExprMutator {
         block_stmt.push_back(block->body);
         cur_id++;
       }
-      new_body.push_back(MakeGroupBlock(block_stmt.size() == 1
-                                            ? block_stmt[0]
-                                            : SeqStmt(std::move(block_stmt)),
-                                        annotations));
+      new_body.push_back(MakeGroupBlock(
+          block_stmt.size() == 1 ? block_stmt[0]
+                                 // NOLINTNEXTLINE(performance-move-const-arg)
+                                 : SeqStmt(std::move(block_stmt)),
+          annotations));
     }
     Array<Integer> order_anno;
     Array<Integer> stage_anno;
@@ -697,10 +698,12 @@ class WSCodeEmitter : public StmtMutator {
             continue;
           if (marker_.GetRole(op->seq[i]) == Role::kBoth) {
             block_stmt.push_back(seq_transformed[i]);
-            new_body.push_back(MakeGroupBlock(
-                block_stmt.size() == 1 ? block_stmt[0]
-                                       : SeqStmt(std::move(block_stmt)),
-                annotations));
+            new_body.push_back(
+                MakeGroupBlock(block_stmt.size() == 1
+                                   ? block_stmt[0]
+                                   // NOLINTNEXTLINE(performance-move-const-arg)
+                                   : SeqStmt(std::move(block_stmt)),
+                               annotations));
             continue;
           }
         }
@@ -734,10 +737,12 @@ class WSCodeEmitter : public StmtMutator {
             }
           }
           collector.Clear();
-          new_body.push_back(MakeGroupBlock(
-              block_stmt.size() == 1 ? block_stmt[0]
-                                     : SeqStmt(std::move(block_stmt)),
-              annotations));
+          new_body.push_back(
+              MakeGroupBlock(block_stmt.size() == 1
+                                 ? block_stmt[0]
+                                 // NOLINTNEXTLINE(performance-move-const-arg)
+                                 : SeqStmt(std::move(block_stmt)),
+                             annotations));
         }
       }
     } else { // consumer case
@@ -766,10 +771,11 @@ class WSCodeEmitter : public StmtMutator {
             }
           }
         }
-        new_body.push_back(MakeGroupBlock(block_stmt.size() == 1
-                                              ? block_stmt[0]
-                                              : SeqStmt(std::move(block_stmt)),
-                                          annotations));
+        new_body.push_back(MakeGroupBlock(
+            block_stmt.size() == 1 ? block_stmt[0]
+                                   // NOLINTNEXTLINE(performance-move-const-arg)
+                                   : SeqStmt(std::move(block_stmt)),
+            annotations));
       }
       // Filter out the producer stmts
       int cur_id = 0;