Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom registry image with create cluster #229

Open
landism opened this issue Jun 1, 2022 · 1 comment
Open

support custom registry image with create cluster #229

landism opened this issue Jun 1, 2022 · 1 comment

Comments

@landism
Copy link
Member

landism commented Jun 1, 2022

The --registry arg to ctlptl create cluster will ensure that ctlptl creates a registry for the cluster it creates.
ctlptl create registry has support for specifying a custom image. If a user creates a registry using that, and then tries to create a cluster using that registry, ctlptl will delete and recreate the registry with the default image (the test, desired.Image (hardcoded to empty string)).

I tried a bit to work around this by first creating the cluster, then deleting the registry, recreating it with a custom image name, and adding it to the docker network, but didn't manage to get it to work. Even if I could get it to work, that rather defeats the point of using ctlptl in the first place.

The two (compatible) main options I see are:

  • add a --registry-image arg to ctlptl create cluster. This would presumably best solve the common case.
  • add some way to tell ctlptl create cluster to skip registry creation and just connect to an existing registry. This would presumably leave a better escape hatch for any similar problem (for example).
@landism
Copy link
Member Author

landism commented Jun 6, 2022

For Chesterton's Fence purposes, Milas confirmed that this was simply an unconsidered use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant