Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should kind be called as a library and not via exec #324

Open
errordeveloper opened this issue Dec 7, 2023 · 2 comments
Open

should kind be called as a library and not via exec #324

errordeveloper opened this issue Dec 7, 2023 · 2 comments

Comments

@errordeveloper
Copy link

sigs.k8s.io/kind is already a dependency, perhaps it could just be invoked as a library?
@nicks
Copy link
Member

nicks commented Dec 7, 2023 •
edited
Loading

🤔 hmmmm not sure. i guess it's not a particularly heavyweight dependency. And it would make other parts of ctlptl simpler, because then we'd only have to support one version of kind.

The downside is that you wouldn't be able to pin older versions of kind, but maybe that's not worth supporting anymore...

@errordeveloper
Copy link
Author

The downside is that you wouldn't be able to pin older versions of kind, but maybe that's not worth supporting anymore...

Isn't that just about what node image you pick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@errordeveloper @nicks