-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol option to port_forward to enable HTTPS services #6427
Comments
thanks for the report! kubectl port-forward uses TCP, it doesn't care about layer 7 (http and https). so visiting https manually will work you can use the i'll leave this open to add support for |
Thanks for the response! I can use the link workaround by creating a |
Describe the Feature You Want
I would like the ability to specify the protocol handler in port forwards so that links to HTTPS services "just work".
Current Behavior
Navigating to an HTTPS service using a
port_forward
link results in a400 Bad Request
fromnginx
.Our current Tiltfile sets up nginx with a certificate trusted by the user's browser. We have a port-forward clause in our Tiltfile that looks like this:
When the user clicks this link, the browser sends an
HTTP
request, giving a 400 Bad Request ("The plain HTTP request was sent to HTTPS port").Why Do You Want This?
Users can work around the bad request by manually prepending
https://
to the URL in their browser navbar. Users find this tedious, as they must do this every time they click the link. It also creates a decent number of questions as new developers run into this issue.Adding an option to set the
protocol
handler in theport_forward
would neatly fix this issue. If I could update myport_forward
to includeprotocol='https'
, then users will no longer need to edit the URL in their browser.Instead of constructing a
localhost:8443
link, this would instead constructhttps://localhost:8443
.The text was updated successfully, but these errors were encountered: