Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO action fails on long commit history #12

Open
Yury-Fridlyand opened this issue Jan 31, 2023 · 5 comments
Open

DCO action fails on long commit history #12

Yury-Fridlyand opened this issue Jan 31, 2023 · 5 comments

Comments

@Yury-Fridlyand
Copy link

tim-actions/dco fails because tim-actions/get-pr-commits produced too big input for it.

An error occurred trying to start process '/home/runner/runners/2.301.1/externals/node12/bin/node' with working directory '/home/runner/work/opensearch-project-sql/opensearch-project-sql'. Argument list too long

I suppose the output of get-pr-commits should be filtered before passed to the next step.

See raw GHA logs: 2.txt

Thanks!

@Tim-Zhang
Copy link
Collaborator

Tim-Zhang commented May 17, 2023

@Yury-Fridlyand I see there are more than 80 commits in the pull request. We have not encountered such a situation so far,
and I don't think filter is a good idea, because get-pr-commits doest know what fields the consumer uses.

If you have any ideas to fix this then pull requests are welcome, thank you

@Tim-Zhang
Copy link
Collaborator

Tim-Zhang commented May 17, 2023

@Yury-Fridlyand Maybe it could be resolved by adding a filter_fields option, what do you think? could you please help to fix this?

@Yury-Fridlyand
Copy link
Author

Hi @Tim-Zhang, thank you for replying!
It is a good idea to make a filter.
Another option I see get-pr-commits to write output into a file and make consumer actions read it. To support having multiple get-pr-commits into a CI workflow they could be distinguished by step ID. A consumer (e.g. dco step) would have ID of producer (get-pr-commits) as an optional argument.

@Tim-Zhang
Copy link
Collaborator

Tim-Zhang commented May 17, 2023

@Yury-Fridlyand That sounds good, store in files is good but should be happened optional in my opinion. Anyway the PR is welcome(I have no time to develop especially do testing recently 😃 ) , I would really appropriate it.

@Yury-Fridlyand
Copy link
Author

I'll try, but I don't want to promise anything - I have no experience creating GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants