Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sampling is implemented incorrectly #34

Open
mcfunley opened this issue Jun 10, 2015 · 0 comments
Open

sampling is implemented incorrectly #34

mcfunley opened this issue Jun 10, 2015 · 0 comments

Comments

@mcfunley
Copy link

This client sends a sample rate over the wire, but doesn't sample the packets sent. One bad result of this is that e.g. calling count('foo', 1, 0.5) causes foo to be double-counted.

See PR 33, which fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcfunley