Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LV2: unique device name generation duplicated with CLAP #34

Closed
swesterfeld opened this issue Jan 26, 2024 · 1 comment
Closed

LV2: unique device name generation duplicated with CLAP #34

swesterfeld opened this issue Jan 26, 2024 · 1 comment
Assignees
@tim-janik
Milestone
v0.4.0

Comments

@swesterfeld
Copy link
Collaborator

For LV2 .ttl storage in the project zip file, we need to generate a unique name - similar to what CLAP needs for storing its state. Currently I copypasted the function - should this be moved to a base class?

https://github.com/swesterfeld/anklang/blob/e70586945ccf9376a78c4f8aa36631bd68c85ef2/ase/lv2device.cc#L2439
@tim-janik
Copy link
Owner

For LV2 .ttl storage in the project zip file, we need to generate a unique name - similar to what CLAP needs for storing its state. Currently I copypasted the function - should this be moved to a base class?

https://github.com/swesterfeld/anklang/blob/e70586945ccf9376a78c4f8aa36631bd68c85ef2/ase/lv2device.cc#L2439

Yeah, it is probably best to move this to DeviceImpl.

@tim-janik tim-janik added this to the v0.4.0 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-janik tim-janik

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@tim-janik @swesterfeld