enhancement(remap): Add to_syslog_level function for parsing Syslog levels into strings #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucperkins
force-pushed
the
to-level-remap-func
branch
from
ca24fe7
to
0f8d3b3
Compare
|
Same as my comment in #5501 . I propose we at least call this |
|
@jszwedko Personally, I'm agnostic on this. Happy to go with the flow re: decisions from our fearless TRL leaders. |
added 8 commits
December 19, 2020 18:02
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
lucperkins
force-pushed
the
to-level-remap-func
branch
from
75954d6
to
5f0ce9d
Compare
added 4 commits
December 19, 2020 18:16
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
jszwedko
reviewed
Dec 21, 2020
There was a problem hiding this comment.
In absence of https://github.com/timberio/vector/issues/5507, which feels like it might be a little ways off, I'd propose calling this to_syslog_level. We can always deprecate it and change to syslog::to_level later.
Otherwise, this looks good to me!
lucperkins
force-pushed
the
to-level-remap-func
branch
from
e9522e8
to
2f4445b
Compare
jszwedko
approved these changes
Dec 21, 2020
lucperkins
changed the title
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Fix dependency naming issues Co-authored-by: Jesse Szwedko <jesse@szwedko.me> Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
lucperkins
force-pushed
the
to-level-remap-func
branch
from
b3de51e
to
592b551
Compare
This was referenced Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5500 with a Remap function that converts Syslog severity levels into their corresponding keyword.
Note: the heavy lifting has been done here. I'm marking this as a draft until (a) #5522 lands and (b) we figure out a naming system for modules/namespaces.