Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 breaks library during extension load #7

Open
vaughnkoch opened this issue Sep 18, 2018 · 0 comments
Open

React 16 breaks library during extension load #7

vaughnkoch opened this issue Sep 18, 2018 · 0 comments

Comments

@vaughnkoch
Copy link

Because of this change in React 16, accessing PropTypes in React now throws an error, which makes it impossible to load the js module.
https://reactjs.org/warnings/dont-call-proptypes.html

The breaking line seems to be line 5 in component.js. I think there's a simple fix available if you follow the above link.

const { bool, object } = React.PropTypes;

Thanks for creating a cool library btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant