Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old useMatches in favor of deep match #124

Closed
3 tasks done
timc1 opened this issue Nov 14, 2021 · 0 comments
Closed
3 tasks done

Remove old useMatches in favor of deep match #124

timc1 opened this issue Nov 14, 2021 · 0 comments
Assignees
@timc1

Comments

@timc1
Copy link
Owner

timc1 commented Nov 14, 2021 •
edited
Loading

Related #120.

It's probably viable now to rename useDeepMatches to useMatches, and remove the current useMatches. This will clean up the API and enable users to not need to do their own array flattening.

  • Remove current useMatches and rename useDeepMatches
  • export useDeepMatches with a deprecation flag to useMatches
  • export useMatches ✔️
@timc1 timc1 self-assigned this Nov 14, 2021
@timc1 timc1 mentioned this issue Nov 21, 2021
Merged
6 tasks
@timc1 timc1 closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timc1 timc1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timc1