Revert "Remove dependency on itoa"

This reverts commit 26cf0ac.

Author: jhpratt

Cargo.lock

@@ -9,6 +9,7 @@ time-macros = { path = "time-macros", version = "=0.2.24" }
 
 criterion = { version = "0.5.1", default-features = false }
 deranged = { version = "0.5.2", features = ["powerfmt"] }
+itoa = "1.0.1"
 js-sys = "0.3.58"
 libc = "0.2.98"
 num-conv = "0.1.0"

Cargo.toml

@@ -32,7 +32,7 @@ rustdoc-args = ["--generate-link-to-definition"]
 [features]
 default = ["std"]
 alloc = ["serde?/alloc"]
-formatting = ["std", "time-macros?/formatting"]
+formatting = ["dep:itoa", "std", "time-macros?/formatting"]
 large-dates = ["time-macros?/large-dates"]
 local-offset = ["std", "dep:libc", "dep:num_threads"]
 macros = ["dep:time-macros"]
@@ -52,6 +52,7 @@ wasm-bindgen = ["dep:js-sys"]
 # feature gate.
 [dependencies]
 deranged = { workspace = true }
+itoa = { workspace = true, optional = true }
 num-conv = { workspace = true }
 powerfmt = { workspace = true }
 quickcheck = { workspace = true, optional = true }

time/Cargo.toml

@@ -5,7 +5,6 @@ mod iso8601;
 
 use core::num::NonZero;
 use std::io;
-use std::string::ToString;
 
 use num_conv::prelude::*;
 
@@ -142,7 +141,7 @@ pub(crate) fn format_float(
 #[inline]
 pub(crate) fn format_number<const WIDTH: u8>(
     output: &mut (impl io::Write + ?Sized),
-    value: impl ToString + DigitCount + Copy,
+    value: impl itoa::Integer + DigitCount + Copy,
     padding: modifier::Padding,
 ) -> Result<usize, io::Error> {
     match padding {
@@ -158,13 +157,13 @@ pub(crate) fn format_number<const WIDTH: u8>(
 #[inline]
 pub(crate) fn format_number_pad_space<const WIDTH: u8>(
     output: &mut (impl io::Write + ?Sized),
-    value: impl ToString + DigitCount + Copy,
+    value: impl itoa::Integer + DigitCount + Copy,
 ) -> Result<usize, io::Error> {
     let mut bytes = 0;
     for _ in 0..(WIDTH.saturating_sub(value.num_digits())) {
         bytes += write(output, b" ")?;
     }
-    bytes += write(output, value.to_string().as_bytes())?;
+    bytes += write(output, itoa::Buffer::new().format(value).as_bytes())?;
     Ok(bytes)
 }
 
@@ -174,13 +173,13 @@ pub(crate) fn format_number_pad_space<const WIDTH: u8>(
 #[inline]
 pub(crate) fn format_number_pad_zero<const WIDTH: u8>(
     output: &mut (impl io::Write + ?Sized),
-    value: impl ToString + DigitCount + Copy,
+    value: impl itoa::Integer + DigitCount + Copy,
 ) -> Result<usize, io::Error> {
     let mut bytes = 0;
     for _ in 0..(WIDTH.saturating_sub(value.num_digits())) {
         bytes += write(output, b"0")?;
     }
-    bytes += write(output, value.to_string().as_bytes())?;
+    bytes += write(output, itoa::Buffer::new().format(value).as_bytes())?;
     Ok(bytes)
 }
 
@@ -190,9 +189,9 @@ pub(crate) fn format_number_pad_zero<const WIDTH: u8>(
 #[inline]
 pub(crate) fn format_number_pad_none(
     output: &mut (impl io::Write + ?Sized),
-    value: impl ToString + Copy,
+    value: impl itoa::Integer + Copy,
 ) -> Result<usize, io::Error> {
-    write(output, value.to_string().as_bytes())
+    write(output, itoa::Buffer::new().format(value).as_bytes())
 }
 
 /// Format the provided component into the designated output. An `Err` will be returned if the