-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make format
methods localizable
#680
Comments
This is something I previously considered when I took over |
@jhpratt Could you make a suggestion for the API? Currently on vacation and willing to take a crack at it if you can provide the general direction, which (as you said) isn't the above suggestion |
I could also just make a suggestion via a PR if that's preferred :D |
For this specifically, I'd prefer not having a PR as it'll involve some code generation that will most likely end up in a separate repository. |
Gotcha! Any way I can help move this forward or support you with this? |
Not really at this point. I have other priorities, so it's not going to happen in the immediate future. |
It should be possible to make
format
methods localizable by passing a structLocalization
with the month and weekday names.This struct is passed down to
fmt_month
andfmt_weekday
methods that used it instead of the hardcodedMONTH_NAMES
andWEEKDAY_NAMES
.The text was updated successfully, but these errors were encountered: