Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Enhancement: remove negated if else condition checks #13

Open
3 tasks done
navin-moorthy opened this issue Mar 30, 2023 · 0 comments
Open
3 tasks done

🚀 Enhancement: remove negated if else condition checks #13

navin-moorthy opened this issue Mar 30, 2023 · 0 comments
Labels
Status: Accepting PRs Please, send a pull request to resolve this! Type: Enhancement Enhancement of the code, not introducing new features.

Comments

@navin-moorthy
Copy link
Contributor

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

https://github.com/timelessco/bookmark-tags/blob/f78547914b01925ec310ad5ae612ad8c4f07f569/.eslintrc.cjs#L16-L17

  • Remove this line from the eslint config & run pnpm lint:eslint
  • Fix all the eslint errors from this rule for better code understanding.
  • This should be happening only in if else cases

Additional Info

No response
@navin-moorthy navin-moorthy added Status: Accepting PRs Please, send a pull request to resolve this! Type: Enhancement Enhancement of the code, not introducing new features. labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Accepting PRs Please, send a pull request to resolve this! Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navin-moorthy