Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for recursive text splitting #207

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Askir
Copy link
Contributor

@Askir Askir commented Nov 8, 2024

No description provided.

@Askir Askir force-pushed the jascha/ai-83-vectorizer-test-recursive-chunk-splitting branch 2 times, most recently from 110d44b to eb20dbd Compare November 8, 2024 20:26
@Askir Askir marked this pull request as ready for review November 8, 2024 20:29
@Askir Askir requested a review from a team as a code owner November 8, 2024 20:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this file shouldn't be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes not sure how this happened, I also thought this was already merged. My bad 😅

Copy link
Contributor

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding the docs/python-integration.md here (empty btw). I guess you want to remove it.

@Askir Askir force-pushed the jascha/ai-83-vectorizer-test-recursive-chunk-splitting branch from eb20dbd to f9a9a2c Compare November 19, 2024 17:00
@Askir Askir requested a review from smoya November 19, 2024 17:05
Copy link
Contributor

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Askir Askir merged commit 4a35fc6 into main Nov 19, 2024
4 checks passed
@Askir Askir deleted the jascha/ai-83-vectorizer-test-recursive-chunk-splitting branch November 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants